RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 21:57:43 +00:00
Code Issues Activity Actions

AK: Don't return empty StringImpl from create() when char* starts with \0

Browse source 
When creating a StringImpl for a C string that starts with a null-byte,
we would ignore the explicitly given length and return the empty
StringImpl - presumably to check for "\0", but this leads to false
positives ("\0foo") so let's only care about the length.
This commit is contained in:
Linus Groh 2020-11-25 19:06:02 +00:00 • committed by Andreas Kling
parent 4e68f179d6
commit 5dcd1c2709
1 changed files with 0 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
AK/StringImpl.cpp
View file

@ -103,9 +103,6 @@ RefPtr<StringImpl> StringImpl::create(const char* cstring, size_t length, Should
if (!cstring) if (!cstring)
return nullptr; return nullptr;
if (!length || !*cstring)
return the_empty_stringimpl();
if (should_chomp) { if (should_chomp) {
while (length) { while (length) {
char last_ch = cstring[length - 1]; char last_ch = cstring[length - 1];