From 5def3b01506aced87063dcb01d947052937c32f2 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Mon, 28 Mar 2022 21:04:21 +0200 Subject: [PATCH] LibWeb: Use LineBox::height() when determining IFC auto heights We don't need to loop through all the fragments on the line to work out how tall it is. Just ask for the height. :^) --- .../Libraries/LibWeb/Layout/InlineFormattingContext.cpp | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/Userland/Libraries/LibWeb/Layout/InlineFormattingContext.cpp b/Userland/Libraries/LibWeb/Layout/InlineFormattingContext.cpp index 69dcf5cc1e..72d5910362 100644 --- a/Userland/Libraries/LibWeb/Layout/InlineFormattingContext.cpp +++ b/Userland/Libraries/LibWeb/Layout/InlineFormattingContext.cpp @@ -69,17 +69,12 @@ void InlineFormattingContext::run(Box const&, LayoutMode layout_mode) generate_line_boxes(layout_mode); - float min_line_height = containing_block().line_height(); float max_line_width = 0; float content_height = 0; for (auto& line_box : m_state.get(containing_block()).line_boxes) { - float max_height = min_line_height; - for (auto& fragment : line_box.fragments()) { - max_height = max(max_height, fragment.border_box_height()); - } max_line_width = max(max_line_width, line_box.width()); - content_height += max_height; + content_height += line_box.height(); } auto& containing_block_state = m_state.get_mutable(containing_block());