From 5dfb4e8066701de991854268f1f6d49d735141c9 Mon Sep 17 00:00:00 2001 From: Tim Ledbetter Date: Mon, 22 May 2023 23:22:30 +0100 Subject: [PATCH] LibC: Fix incorrect string length calculation in getsignalbyname() This makes `kill` and `killall` work correctly with signal names. --- Userland/Libraries/LibC/signal.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Userland/Libraries/LibC/signal.cpp b/Userland/Libraries/LibC/signal.cpp index 946747c2dd..e61781a87a 100644 --- a/Userland/Libraries/LibC/signal.cpp +++ b/Userland/Libraries/LibC/signal.cpp @@ -252,7 +252,7 @@ int getsignalbyname(char const* name) VERIFY(name); StringView name_sv { name, strlen(name) }; for (size_t i = 0; i < NSIG; ++i) { - StringView signal_name { sys_signame[i], sizeof(sys_signame[i]) - 1 }; + StringView signal_name { sys_signame[i], strlen(sys_signame[i]) }; if (signal_name == name_sv || (name_sv.starts_with("SIG"sv) && signal_name == name_sv.substring_view(3))) return i; }