RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 19:17:35 +00:00
Code Issues Activity Actions

LibGL: Optimize float divisions in unpack_color

Browse source 
For Tux Racer on my machine, this function would account for 15% of
samples. After this change, that drops down to 9%.
This commit is contained in:
Jelle Raaijmakers 2021-12-28 22:56:12 +01:00 • committed by Andreas Kling
parent 8d8f74e334
commit 5e01ca29c5
1 changed files with 17 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

33
Userland/Libraries/LibSoftGPU/ImageFormat.h
View file

@ -36,41 +36,42 @@ inline static constexpr size_t element_size(ImageFormat format)
inline static FloatVector4 unpack_color(void const* ptr, ImageFormat format) inline static FloatVector4 unpack_color(void const* ptr, ImageFormat format)
{ {
constexpr auto one_over_255 = 1.0f / 255;
switch (format) { switch (format) {
case ImageFormat::RGB888: { case ImageFormat::RGB888: {
auto rgb = reinterpret_cast<u8 const*>(ptr); auto rgb = reinterpret_cast<u8 const*>(ptr);
return { return {
rgb[0] / 255.f, rgb[0] * one_over_255,
rgb[1] / 255.f, rgb[1] * one_over_255,
rgb[2] / 255.f, rgb[2] * one_over_255,
1.0f 1.0f,
}; };
} }
case ImageFormat::BGR888: { case ImageFormat::BGR888: {
auto bgr = reinterpret_cast<u8 const*>(ptr); auto bgr = reinterpret_cast<u8 const*>(ptr);
return { return {
bgr[2] / 255.f, bgr[2] * one_over_255,
bgr[1] / 255.f, bgr[1] * one_over_255,
bgr[0] / 255.f, bgr[0] * one_over_255,
1.0f 1.0f,
}; };
} }
case ImageFormat::RGBA8888: { case ImageFormat::RGBA8888: {
auto rgba = *reinterpret_cast<u32 const*>(ptr); auto rgba = *reinterpret_cast<u32 const*>(ptr);
return { return {
(rgba & 0xff) / 255.f, (rgba & 0xff) * one_over_255,
((rgba >> 8) & 0xff) / 255.f, ((rgba >> 8) & 0xff) * one_over_255,
((rgba >> 16) & 0xff) / 255.f, ((rgba >> 16) & 0xff) * one_over_255,
((rgba >> 24) & 0xff) / 255.f ((rgba >> 24) & 0xff) * one_over_255,
}; };
} }
case ImageFormat::BGRA8888: { case ImageFormat::BGRA8888: {
auto bgra = *reinterpret_cast<u32 const*>(ptr); auto bgra = *reinterpret_cast<u32 const*>(ptr);
return { return {
((bgra >> 16) & 0xff) / 255.f, ((bgra >> 16) & 0xff) * one_over_255,
((bgra >> 8) & 0xff) / 255.f, ((bgra >> 8) & 0xff) * one_over_255,
(bgra & 0xff) / 255.f, (bgra & 0xff) * one_over_255,
((bgra >> 24) & 0xff) / 255.f ((bgra >> 24) & 0xff) * one_over_255,
}; };
} }
case ImageFormat::RGB565: { case ImageFormat::RGB565: {