RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 06:47:34 +00:00
Code Issues Activity Actions

Everywhere: Rename {Deprecated => Byte}String

Browse source 
This commit un-deprecates DeprecatedString, and repurposes it as a byte
string.
As the null state has already been removed, there are no other
particularly hairy blockers in repurposing this type as a byte string
(what it _really_ is).

This commit is auto-generated:
  $ xs=$(ack -l \bDeprecatedString\b\|deprecated_string AK Userland \
    Meta Ports Ladybird Tests Kernel)
  $ perl -pie 's/\bDeprecatedString\b/ByteString/g;
    s/deprecated_string/byte_string/g' $xs
  $ clang-format --style=file -i \
    $(git diff --name-only | grep \.cpp\|\.h)
  $ gn format $(git ls-files '*.gn' '*.gni')
This commit is contained in:
Ali Mohammad Pur 2023-12-16 17:49:34 +03:30 • committed by Ali Mohammad Pur
parent 38d62563b3
commit 5e1499d104
1615 changed files with 10257 additions and 10257 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Applications/PartitionEditor/PartitionModel.cpp
View file

@ -65,7 +65,7 @@ GUI::Variant PartitionModel::data(GUI::ModelIndex const& index, GUI::ModelRole r
return {};
}
ErrorOr<void> PartitionModel::set_device_path(DeprecatedString const& path)
ErrorOr<void> PartitionModel::set_device_path(ByteString const& path)
{
auto strong_file = TRY(Core::File::open(path, Core::File::OpenMode::Read));
auto weak_file = TRY(Core::File::adopt_fd(strong_file->fd(), Core::File::OpenMode::Read, Core::File::ShouldCloseFileDescriptor::No));

2
Userland/Applications/PartitionEditor/PartitionModel.h
View file

@ -31,7 +31,7 @@ public:
virtual ErrorOr<String> column_name(int) const override;
virtual GUI::Variant data(GUI::ModelIndex const&, GUI::ModelRole) const override;
ErrorOr<void> set_device_path(DeprecatedString const&);
ErrorOr<void> set_device_path(ByteString const&);
private:
PartitionModel() = default;

8
Userland/Applications/PartitionEditor/main.cpp
View file

@ -17,9 +17,9 @@
#include <LibGUI/TableView.h>
#include <unistd.h>
static Vector<DeprecatedString> get_device_paths()
static Vector<ByteString> get_device_paths()
{
auto device_paths = Vector<DeprecatedString>();
auto device_paths = Vector<ByteString>();
// FIXME: Propagate errors.
(void)Core::Directory::for_each_entry("/dev"sv, Core::DirIterator::Flags::SkipParentAndBaseDir, [&](auto const& entry, auto const& directory) -> ErrorOr<IterationDecision> {
auto full_path = LexicalPath::join(directory.path().string(), entry.name).string();
@ -67,13 +67,13 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
TRY(partition_model->set_device_path(device_paths.first()));
auto& device_combobox = *widget->find_descendant_of_type_named<GUI::ComboBox>("device_combobox");
device_combobox.set_model(GUI::ItemListModel<DeprecatedString>::create(device_paths));
device_combobox.set_model(GUI::ItemListModel<ByteString>::create(device_paths));
device_combobox.set_only_allow_values_from_model(true);
device_combobox.set_selected_index(0);
device_combobox.on_change = [&](auto const& path, auto const&) {
auto result = partition_model->set_device_path(path);
if (result.is_error())
GUI::MessageBox::show_error(window, DeprecatedString::formatted("No partition table found for device {}", path));
GUI::MessageBox::show_error(window, ByteString::formatted("No partition table found for device {}", path));
};
auto& partition_table_view = *widget->find_descendant_of_type_named<GUI::TableView>("partition_table_view");