RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 15:17:36 +00:00
Code Issues Activity Actions

Everywhere: Rename {Deprecated => Byte}String

Browse source 
This commit un-deprecates DeprecatedString, and repurposes it as a byte
string.
As the null state has already been removed, there are no other
particularly hairy blockers in repurposing this type as a byte string
(what it _really_ is).

This commit is auto-generated:
  $ xs=$(ack -l \bDeprecatedString\b\|deprecated_string AK Userland \
    Meta Ports Ladybird Tests Kernel)
  $ perl -pie 's/\bDeprecatedString\b/ByteString/g;
    s/deprecated_string/byte_string/g' $xs
  $ clang-format --style=file -i \
    $(git diff --name-only | grep \.cpp\|\.h)
  $ gn format $(git ls-files '*.gn' '*.gni')
This commit is contained in:
Ali Mohammad Pur 2023-12-16 17:49:34 +03:30 • committed by Ali Mohammad Pur
parent 38d62563b3
commit 5e1499d104
1615 changed files with 10257 additions and 10257 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Applications/Piano/ProcessorParameterWidget/Dropdown.h
View file

@ -20,12 +20,12 @@ class ProcessorParameterDropdown : public GUI::ComboBox {
C_OBJECT(ProcessorParameterDropdown);
public:
ProcessorParameterDropdown(DSP::ProcessorEnumParameter<EnumT>& parameter, Vector<DeprecatedString> modes)
ProcessorParameterDropdown(DSP::ProcessorEnumParameter<EnumT>& parameter, Vector<ByteString> modes)
: ComboBox()
, m_parameter(parameter)
, m_modes(move(modes))
{
auto model = GUI::ItemListModel<EnumT, Vector<DeprecatedString>>::create(m_modes);
auto model = GUI::ItemListModel<EnumT, Vector<ByteString>>::create(m_modes);
set_model(model);
set_only_allow_values_from_model(true);
set_model_column(0);
@ -55,5 +55,5 @@ public:
private:
DSP::ProcessorEnumParameter<EnumT>& m_parameter;
Vector<DeprecatedString> m_modes;
Vector<ByteString> m_modes;
};

2
Userland/Applications/Piano/ProcessorParameterWidget/ParameterWidget.cpp
View file

@ -26,7 +26,7 @@ ProcessorParameterWidget::ProcessorParameterWidget(DSP::ProcessorParameter& raw_
case DSP::ParameterType::Enum: {
// FIXME: We shouldn't do that, but the only user is the synth right now.
auto& parameter = static_cast<DSP::ProcessorEnumParameter<DSP::Synthesizers::Waveform>&>(raw_parameter);
auto enum_strings = Vector<DeprecatedString> { "Sine", "Triangle", "Square", "Saw", "Noise" };
auto enum_strings = Vector<ByteString> { "Sine", "Triangle", "Square", "Saw", "Noise" };
m_parameter_modifier = add<ProcessorParameterDropdown<DSP::Synthesizers::Waveform>>(parameter, move(enum_strings));
break;
}