RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 22:47:44 +00:00
Code Issues Activity Actions

Everywhere: Rename {Deprecated => Byte}String

Browse source 
This commit un-deprecates DeprecatedString, and repurposes it as a byte
string.
As the null state has already been removed, there are no other
particularly hairy blockers in repurposing this type as a byte string
(what it _really_ is).

This commit is auto-generated:
  $ xs=$(ack -l \bDeprecatedString\b\|deprecated_string AK Userland \
    Meta Ports Ladybird Tests Kernel)
  $ perl -pie 's/\bDeprecatedString\b/ByteString/g;
    s/deprecated_string/byte_string/g' $xs
  $ clang-format --style=file -i \
    $(git diff --name-only | grep \.cpp\|\.h)
  $ gn format $(git ls-files '*.gn' '*.gni')
This commit is contained in:
Ali Mohammad Pur 2023-12-16 17:49:34 +03:30 • committed by Ali Mohammad Pur
parent 38d62563b3
commit 5e1499d104
1615 changed files with 10257 additions and 10257 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Applications/PixelPaint/Tools/GuideTool.cpp
View file

@ -140,7 +140,7 @@ void GuideTool::on_context_menu(Layer*, GUI::ContextMenuEvent& event)
return;
auto dialog = EditGuideDialog::construct(
editor()->window(),
DeprecatedString::formatted("{}", m_context_menu_guide->offset()),
ByteString::formatted("{}", m_context_menu_guide->offset()),
m_context_menu_guide->orientation());
if (dialog->exec() != GUI::Dialog::ExecResult::OK)
return;

2
Userland/Applications/PixelPaint/Tools/RectangleSelectTool.cpp
View file

@ -209,7 +209,7 @@ NonnullRefPtr<GUI::Widget> RectangleSelectTool::get_properties_widget()
auto& mode_combo = mode_container.add<GUI::ComboBox>();
mode_combo.set_only_allow_values_from_model(true);
mode_combo.set_model(*GUI::ItemListModel<DeprecatedString>::create(m_merge_mode_names));
mode_combo.set_model(*GUI::ItemListModel<ByteString>::create(m_merge_mode_names));
mode_combo.set_selected_index((int)m_merge_mode);
mode_combo.on_change = [this](auto&&, GUI::ModelIndex const& index) {
VERIFY(index.row() >= 0);

2
Userland/Applications/PixelPaint/Tools/RectangleSelectTool.h
View file

@ -40,7 +40,7 @@ private:
};
RefPtr<GUI::Widget> m_properties_widget;
Vector<DeprecatedString> m_merge_mode_names {};
Vector<ByteString> m_merge_mode_names {};
Selection::MergeMode m_merge_mode { Selection::MergeMode::Set };
float m_edge_feathering { 0.0f };
bool m_selecting { false };

2
Userland/Applications/PixelPaint/Tools/WandSelectTool.cpp
View file

@ -122,7 +122,7 @@ NonnullRefPtr<GUI::Widget> WandSelectTool::get_properties_widget()
auto& mode_combo = mode_container.add<GUI::ComboBox>();
mode_combo.set_only_allow_values_from_model(true);
mode_combo.set_model(*GUI::ItemListModel<DeprecatedString>::create(m_merge_mode_names));
mode_combo.set_model(*GUI::ItemListModel<ByteString>::create(m_merge_mode_names));
mode_combo.set_selected_index((int)m_merge_mode);
mode_combo.on_change = [this](auto&&, GUI::ModelIndex const& index) {
VERIFY(index.row() >= 0);

2
Userland/Applications/PixelPaint/Tools/WandSelectTool.h
View file

@ -31,7 +31,7 @@ private:
int m_threshold { 0 };
RefPtr<GUI::Widget> m_properties_widget;
Vector<DeprecatedString> m_merge_mode_names {};
Vector<ByteString> m_merge_mode_names {};
Selection::MergeMode m_merge_mode { Selection::MergeMode::Set };
};