RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 07:17:35 +00:00
Code Issues Activity Actions

Everywhere: Rename {Deprecated => Byte}String

Browse source 
This commit un-deprecates DeprecatedString, and repurposes it as a byte
string.
As the null state has already been removed, there are no other
particularly hairy blockers in repurposing this type as a byte string
(what it _really_ is).

This commit is auto-generated:
  $ xs=$(ack -l \bDeprecatedString\b\|deprecated_string AK Userland \
    Meta Ports Ladybird Tests Kernel)
  $ perl -pie 's/\bDeprecatedString\b/ByteString/g;
    s/deprecated_string/byte_string/g' $xs
  $ clang-format --style=file -i \
    $(git diff --name-only | grep \.cpp\|\.h)
  $ gn format $(git ls-files '*.gn' '*.gni')
This commit is contained in:
Ali Mohammad Pur 2023-12-16 17:49:34 +03:30 • committed by Ali Mohammad Pur
parent 38d62563b3
commit 5e1499d104
1615 changed files with 10257 additions and 10257 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Games/Hearts/Game.cpp
View file

@ -147,7 +147,7 @@ void Game::show_score_card(bool game_over)
title_builder.append("Score Card"sv);
if (game_over)
title_builder.append(" - Game Over"sv);
score_dialog->set_title(title_builder.to_deprecated_string());
score_dialog->set_title(title_builder.to_byte_string());
RefPtr<Core::Timer> close_timer;
if (!m_players[0].is_human) {
@ -160,7 +160,7 @@ void Game::show_score_card(bool game_over)
score_dialog->exec();
}
void Game::setup(DeprecatedString player_name, int hand_number)
void Game::setup(ByteString player_name, int hand_number)
{
m_players[0].name = move(player_name);
@ -619,7 +619,7 @@ void Game::play_card(Player& player, size_t card_index)
0);
}
bool Game::is_valid_play(Player& player, Card& card, DeprecatedString* explanation) const
bool Game::is_valid_play(Player& player, Card& card, ByteString* explanation) const
{
// First card must be 2 of Clubs.
if (m_trick_number == 0 && m_trick.is_empty()) {
@ -692,7 +692,7 @@ void Game::card_clicked_during_passing(size_t, Card& card)
void Game::card_clicked_during_play(size_t card_index, Card& card)
{
DeprecatedString explanation;
ByteString explanation;
if (!is_valid_play(m_players[0], card, &explanation)) {
if (m_inverted_card)
m_inverted_card->set_inverted(false);