RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 17:37:34 +00:00
Code Issues Activity Actions

Everywhere: Rename {Deprecated => Byte}String

Browse source 
This commit un-deprecates DeprecatedString, and repurposes it as a byte
string.
As the null state has already been removed, there are no other
particularly hairy blockers in repurposing this type as a byte string
(what it _really_ is).

This commit is auto-generated:
  $ xs=$(ack -l \bDeprecatedString\b\|deprecated_string AK Userland \
    Meta Ports Ladybird Tests Kernel)
  $ perl -pie 's/\bDeprecatedString\b/ByteString/g;
    s/deprecated_string/byte_string/g' $xs
  $ clang-format --style=file -i \
    $(git diff --name-only | grep \.cpp\|\.h)
  $ gn format $(git ls-files '*.gn' '*.gni')
This commit is contained in:
Ali Mohammad Pur 2023-12-16 17:49:34 +03:30 • committed by Ali Mohammad Pur
parent 38d62563b3
commit 5e1499d104
1615 changed files with 10257 additions and 10257 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibWeb/Layout/ListItemMarkerBox.cpp
View file

@ -24,25 +24,25 @@ ListItemMarkerBox::ListItemMarkerBox(DOM::Document& document, CSS::ListStyleType
case CSS::ListStyleType::DisclosureOpen:
break;
case CSS::ListStyleType::Decimal:
m_text = DeprecatedString::formatted("{}.", m_index);
m_text = ByteString::formatted("{}.", m_index);
break;
case CSS::ListStyleType::DecimalLeadingZero:
// This is weird, but in accordance to spec.
m_text = m_index < 10 ? DeprecatedString::formatted("0{}.", m_index) : DeprecatedString::formatted("{}.", m_index);
m_text = m_index < 10 ? ByteString::formatted("0{}.", m_index) : ByteString::formatted("{}.", m_index);
break;
case CSS::ListStyleType::LowerAlpha:
case CSS::ListStyleType::LowerLatin:
m_text = DeprecatedString::bijective_base_from(m_index - 1).to_lowercase();
m_text = ByteString::bijective_base_from(m_index - 1).to_lowercase();
break;
case CSS::ListStyleType::UpperAlpha:
case CSS::ListStyleType::UpperLatin:
m_text = DeprecatedString::bijective_base_from(m_index - 1);
m_text = ByteString::bijective_base_from(m_index - 1);
break;
case CSS::ListStyleType::LowerRoman:
m_text = DeprecatedString::roman_number_from(m_index).to_lowercase();
m_text = ByteString::roman_number_from(m_index).to_lowercase();
break;
case CSS::ListStyleType::UpperRoman:
m_text = DeprecatedString::roman_number_from(m_index);
m_text = ByteString::roman_number_from(m_index);
break;
case CSS::ListStyleType::None:
break;

4
Userland/Libraries/LibWeb/Layout/ListItemMarkerBox.h
View file

@ -18,7 +18,7 @@ public:
explicit ListItemMarkerBox(DOM::Document&, CSS::ListStyleType, CSS::ListStylePosition, size_t index, NonnullRefPtr<CSS::StyleProperties>);
virtual ~ListItemMarkerBox() override;
Optional<DeprecatedString> const& text() const { return m_text; }
Optional<ByteString> const& text() const { return m_text; }
virtual JS::GCPtr<Painting::Paintable> create_paintable() const override;
@ -33,7 +33,7 @@ private:
CSS::ListStylePosition m_list_style_position { CSS::ListStylePosition::Outside };
size_t m_index;
Optional<DeprecatedString> m_text {};
Optional<ByteString> m_text {};
};
template<>

4
Userland/Libraries/LibWeb/Layout/Node.cpp
View file

@ -880,7 +880,7 @@ bool Node::is_root_element() const
return is<HTML::HTMLHtmlElement>(*dom_node());
}
DeprecatedString Node::debug_description() const
ByteString Node::debug_description() const
{
StringBuilder builder;
builder.append(class_name());
@ -896,7 +896,7 @@ DeprecatedString Node::debug_description() const
} else {
builder.append("(anonymous)"sv);
}
return builder.to_deprecated_string();
return builder.to_byte_string();
}
CSS::Display Node::display() const

2
Userland/Libraries/LibWeb/Layout/Node.h
View file

@ -85,7 +85,7 @@ public:
bool is_root_element() const;
DeprecatedString debug_description() const;
ByteString debug_description() const;
bool has_style() const { return m_has_style; }
bool has_style_or_parent_with_style() const;