RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-15 07:14:58 +00:00
Code Issues Activity Actions

Kernel: Avoid ninja-import of global variable

Browse source 
This would have caused an issue later when we enable -Wmissing-declarations, as
the compiler didn't see that Kernel::all_inodes() was being used elsewhere, too.
Also, this means that if the type changes later, there's not going to be weird
run-time issues, but rather a nice type error during compile time.
This commit is contained in:
Ben Wiederhake 2020-08-10 23:55:10 +02:00 • committed by Andreas Kling
parent ef9a3b8e46
commit 5e48eda218
3 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Kernel/FileSystem/ProcFS.cpp
View file

@ -900,10 +900,9 @@ static Optional<KBuffer> procfs$all(InodeIdentifier)
static Optional<KBuffer> procfs$inodes(InodeIdentifier)
{
extern InlineLinkedList<Inode>& all_inodes();
KBufferBuilder builder;
InterruptDisabler disabler;
for (auto& inode : all_inodes()) {
for (auto& inode : Inode::all_with_lock()) {
builder.appendf("Inode{K%x} %02u:%08u (%u)\n", &inode, inode.fsid(), inode.index(), inode.ref_count());
}
return builder.build();