From 5e9395b808f0500ed3745a1c514c3aa701b34b99 Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Sun, 25 Feb 2024 09:29:28 -0500 Subject: [PATCH] pdf: Make render_page() take a Page instead of page_index No behavior change. --- Userland/Utilities/pdf.cpp | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/Userland/Utilities/pdf.cpp b/Userland/Utilities/pdf.cpp index 72f7ef4ca5..e36e7a8fc5 100644 --- a/Userland/Utilities/pdf.cpp +++ b/Userland/Utilities/pdf.cpp @@ -47,10 +47,8 @@ static PDF::PDFErrorOr print_document_info(PDF::Document& document) return {}; } -static PDF::PDFErrorOr> render_page(PDF::Document& document, int page_index) +static PDF::PDFErrorOr> render_page(PDF::Document& document, PDF::Page const& page) { - auto page = TRY(document.get_page(page_index)); - auto page_size = Gfx::IntSize { 800, round_to(800 * page.media_box.height() / page.media_box.width()) }; auto bitmap = TRY(Gfx::Bitmap::create(Gfx::BitmapFormat::BGRx8888, page_size)); @@ -63,11 +61,11 @@ static PDF::PDFErrorOr> render_page(PDF::Document& do return bitmap; } -static PDF::PDFErrorOr> render_page_to_memory(PDF::Document& document, int page_index, int repeats) +static PDF::PDFErrorOr> render_page_to_memory(PDF::Document& document, PDF::Page const& page, int repeats) { - auto bitmap = TRY(render_page(document, page_index)); + auto bitmap = TRY(render_page(document, page)); for (int i = 0; i < repeats - 1; ++i) - (void)TRY(render_page(document, page_index)); + (void)TRY(render_page(document, page)); return bitmap; } @@ -261,7 +259,8 @@ static PDF::PDFErrorOr pdf_main(Main::Arguments arguments) } if (!render_path.is_empty() || render_bench) { - auto bitmap = TRY(render_page_to_memory(document, page_index, render_repeats)); + auto page = TRY(document->get_page(page_index)); + auto bitmap = TRY(render_page_to_memory(document, page, render_repeats)); if (!render_path.is_empty()) TRY(save_rendered_page(move(bitmap), render_path)); return 0;