From 5e9f6f2e2c3890bf4704731a2eaf70ee448306ce Mon Sep 17 00:00:00 2001 From: Linus Groh Date: Tue, 8 Dec 2020 23:45:53 +0000 Subject: [PATCH] LibWeb: Disallow construction of XMLHttpRequest without 'new' The XMLHttpRequest interface only has a constructor and isn't supposed to be callable as a function. https://xhr.spec.whatwg.org/#constructors --- Libraries/LibWeb/Bindings/XMLHttpRequestConstructor.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Libraries/LibWeb/Bindings/XMLHttpRequestConstructor.cpp b/Libraries/LibWeb/Bindings/XMLHttpRequestConstructor.cpp index 943fd0be02..636a7bd461 100644 --- a/Libraries/LibWeb/Bindings/XMLHttpRequestConstructor.cpp +++ b/Libraries/LibWeb/Bindings/XMLHttpRequestConstructor.cpp @@ -57,7 +57,8 @@ XMLHttpRequestConstructor::~XMLHttpRequestConstructor() JS::Value XMLHttpRequestConstructor::call() { - return construct(*this); + vm().throw_exception(global_object(), JS::ErrorType::ConstructorWithoutNew, "XMLHttpRequest"); + return {}; } JS::Value XMLHttpRequestConstructor::construct(Function&)