1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 18:37:35 +00:00

LibWebView: Do not block the console for the initial message request

If we set m_waiting_for_messages to true for the intial message request,
we might never receive a response, and block the console from requesting
any more messages indefinitely. Instead, issue a non-blocking initial
request, which is how the Qt and Serenity chromes behaved before the
ConsoleClient abstraction.

This also changes ConsoleClient::clear() to use run_javascript() rather
than js_console_input(), as that is also how the chromes used to behave.
This commit is contained in:
Timothy Flynn 2023-08-30 06:45:08 -04:00 committed by Tim Flynn
parent f56b772b29
commit 5eb0f65cc0
2 changed files with 3 additions and 9 deletions

View file

@ -33,7 +33,6 @@ private:
void print_html(StringView);
void request_console_messages();
void request_console_messages(i32 start_index);
void begin_group(StringView label, bool start_expanded);
void end_group();