From 5ef01e562ab3cab49421f499de398546757d7192 Mon Sep 17 00:00:00 2001 From: Caoimhe Date: Tue, 20 Jun 2023 16:30:06 +0100 Subject: [PATCH] LibWeb: Generate JavaScript bindings for `CSSKeyframesRule` This one also needs a bit of work, but it's a nice start. --- Userland/Libraries/LibWeb/CSS/CSSKeyframesRule.h | 6 ++++++ Userland/Libraries/LibWeb/CSS/CSSKeyframesRule.idl | 12 ++++++++---- Userland/Libraries/LibWeb/idl_files.cmake | 1 + 3 files changed, 15 insertions(+), 4 deletions(-) diff --git a/Userland/Libraries/LibWeb/CSS/CSSKeyframesRule.h b/Userland/Libraries/LibWeb/CSS/CSSKeyframesRule.h index 6c67f6cbc7..5a17c5dc09 100644 --- a/Userland/Libraries/LibWeb/CSS/CSSKeyframesRule.h +++ b/Userland/Libraries/LibWeb/CSS/CSSKeyframesRule.h @@ -32,6 +32,12 @@ public: Vector> const& keyframes() const { return m_keyframes; } FlyString const& name() const { return m_name; } + size_t length() { return m_keyframes.size(); } + + void set_name(DeprecatedString const& name) + { + m_name = FlyString::from_utf8(name.view()).release_value_but_fixme_should_propagate_errors(); + } private: CSSKeyframesRule(JS::Realm& realm, FlyString name, Vector> keyframes) diff --git a/Userland/Libraries/LibWeb/CSS/CSSKeyframesRule.idl b/Userland/Libraries/LibWeb/CSS/CSSKeyframesRule.idl index e307938403..2f8d3d353e 100644 --- a/Userland/Libraries/LibWeb/CSS/CSSKeyframesRule.idl +++ b/Userland/Libraries/LibWeb/CSS/CSSKeyframesRule.idl @@ -3,11 +3,15 @@ [Exposed=Window] interface CSSKeyframesRule : CSSRule { attribute CSSOMString name; - readonly attribute CSSRuleList cssRules; readonly attribute unsigned long length; +// FIXME: Implement this +// readonly attribute CSSRuleList cssRules; + getter CSSKeyframeRule (unsigned long index); - undefined appendRule(CSSOMString rule); - undefined deleteRule(CSSOMString select); - CSSKeyframeRule? findRule(CSSOMString select); + +// FIXME: Implement these +// undefined appendRule(CSSOMString rule); +// undefined deleteRule(CSSOMString select); +// CSSKeyframeRule? findRule(CSSOMString select); }; diff --git a/Userland/Libraries/LibWeb/idl_files.cmake b/Userland/Libraries/LibWeb/idl_files.cmake index 69168c7884..7af1b14a99 100644 --- a/Userland/Libraries/LibWeb/idl_files.cmake +++ b/Userland/Libraries/LibWeb/idl_files.cmake @@ -8,6 +8,7 @@ libweb_js_bindings(CSS/CSSFontFaceRule) libweb_js_bindings(CSS/CSSGroupingRule) libweb_js_bindings(CSS/CSSImportRule) libweb_js_bindings(CSS/CSSKeyframeRule) +libweb_js_bindings(CSS/CSSKeyframesRule) libweb_js_bindings(CSS/CSSMediaRule) libweb_js_bindings(CSS/CSS NAMESPACE) libweb_js_bindings(CSS/CSSRule)