From 5f473bcb5f4486a93d90bd8cb58192521a4768e9 Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Mon, 15 May 2023 09:50:42 -0400 Subject: [PATCH] LibWeb: Propagate non-primary mouse button clicks on video elements Otherwise, returning "no" here will disallow the browser process from showing a context menu, as the event handler will bail early. --- Userland/Libraries/LibWeb/Painting/VideoPaintable.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Userland/Libraries/LibWeb/Painting/VideoPaintable.cpp b/Userland/Libraries/LibWeb/Painting/VideoPaintable.cpp index 661fbed6a3..ccc697aaa6 100644 --- a/Userland/Libraries/LibWeb/Painting/VideoPaintable.cpp +++ b/Userland/Libraries/LibWeb/Painting/VideoPaintable.cpp @@ -349,7 +349,7 @@ void VideoPaintable::paint_placeholder_video_controls(PaintContext& context, Dev VideoPaintable::DispatchEventOfSameName VideoPaintable::handle_mouseup(Badge, CSSPixelPoint position, unsigned button, unsigned) { if (button != GUI::MouseButton::Primary) - return DispatchEventOfSameName::No; + return DispatchEventOfSameName::Yes; auto& video_element = layout_box().dom_node(); auto const& cached_layout_boxes = video_element.cached_layout_boxes({});