From 5f552ddc5cfade2748a6adf2c732ca4238ac1ad2 Mon Sep 17 00:00:00 2001 From: Kenneth Myhra Date: Tue, 14 Feb 2023 20:45:54 +0100 Subject: [PATCH] LibWeb: Make factory method of DOM::AbortController fallible --- Userland/Libraries/LibWeb/DOM/AbortController.cpp | 4 ++-- Userland/Libraries/LibWeb/DOM/AbortController.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Userland/Libraries/LibWeb/DOM/AbortController.cpp b/Userland/Libraries/LibWeb/DOM/AbortController.cpp index f2d9bc015a..732f58d87d 100644 --- a/Userland/Libraries/LibWeb/DOM/AbortController.cpp +++ b/Userland/Libraries/LibWeb/DOM/AbortController.cpp @@ -10,10 +10,10 @@ namespace Web::DOM { -JS::NonnullGCPtr AbortController::construct_impl(JS::Realm& realm) +WebIDL::ExceptionOr> AbortController::construct_impl(JS::Realm& realm) { auto signal = AbortSignal::construct_impl(realm); - return realm.heap().allocate(realm, realm, move(signal)).release_allocated_value_but_fixme_should_propagate_errors(); + return MUST_OR_THROW_OOM(realm.heap().allocate(realm, realm, move(signal))); } // https://dom.spec.whatwg.org/#dom-abortcontroller-abortcontroller diff --git a/Userland/Libraries/LibWeb/DOM/AbortController.h b/Userland/Libraries/LibWeb/DOM/AbortController.h index 9ede4bab2e..0176fa1d7b 100644 --- a/Userland/Libraries/LibWeb/DOM/AbortController.h +++ b/Userland/Libraries/LibWeb/DOM/AbortController.h @@ -16,7 +16,7 @@ class AbortController final : public Bindings::PlatformObject { WEB_PLATFORM_OBJECT(AbortController, Bindings::PlatformObject); public: - static JS::NonnullGCPtr construct_impl(JS::Realm&); + static WebIDL::ExceptionOr> construct_impl(JS::Realm&); virtual ~AbortController() override;