RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 09:37:45 +00:00
Code Issues Activity Actions

WindowServer: Improve client write handling a little

Browse source 
* EPIPE now correctly deletes the client connection
* EAGAIN (which is now returned by the kernel if the write buffer fills)
  terminates the connection also
This commit is contained in:
Robin Burchell 2019-05-19 10:26:06 +02:00 • committed by Andreas Kling
parent d8b74c8c86
commit 5f597d0cb2
1 changed files with 12 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Servers/WindowServer/WSClientConnection.cpp
View file

@ -92,12 +92,21 @@ void WSClientConnection::post_message(const WSAPI_ServerMessage& message, const
int nwritten = writev(m_fd, iov, iov_count); int nwritten = writev(m_fd, iov, iov_count);
if (nwritten < 0) { if (nwritten < 0) {
if (errno == EPIPE) { switch (errno) {
case EPIPE:
dbgprintf("WSClientConnection::post_message: Disconnected from peer.\n"); dbgprintf("WSClientConnection::post_message: Disconnected from peer.\n");
delete_later();
return; return;
break;
case EAGAIN:
dbgprintf("WSClientConnection::post_message: Client buffer overflowed.\n");
did_misbehave();
return;
break;
default:
perror("WSClientConnection::post_message writev");
ASSERT_NOT_REACHED();
} }
perror("WSClientConnection::post_message writev");
ASSERT_NOT_REACHED();
} }
ASSERT(nwritten == sizeof(message) + extra_data.size()); ASSERT(nwritten == sizeof(message) + extra_data.size());