RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 13:48:12 +00:00
Code Issues Activity Actions

Kernel+LibC: Default to 8-bit characters in TTY

Browse source 
Some ports (like `bc` with history enabled) sensibly set the termios
character size to 8 bits.

Previously, we left the character size value (given by the bitmask
CSIZE) as zero by default (meaning 5 bits per character), and returned
ENOTIMPL whenever someone modified it. This was dumb.
This commit is contained in:
Daniel Bertalan 2021-10-25 14:36:05 +02:00 • committed by Andreas Kling
parent 0e68550c05
commit 5f6030b13c
2 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Kernel/TTY/TTY.cpp
View file

@ -438,12 +438,12 @@ KResult TTY::set_termios(const termios& t)
}
}
if ((m_termios.c_cflag & CSIZE) != CS8) {
dbgln("FIXME: Character sizes other than 8 bits are not supported");
rc = ENOTIMPL;
}
static constexpr FlagDescription unimplemented_cflags[] = {
{ CSIZE, "CSIZE" },
{ CS5, "CS5" },
{ CS6, "CS6" },
{ CS7, "CS7" },
{ CS8, "CS8" },
{ CSTOPB, "CSTOPB" },
{ CREAD, "CREAD" },
{ PARENB, "PARENB" },