AK+Everywhere: Stop including Vector.h from StringView.h

Preparation for using Error.h from Vector.h. This required moving some
things out of line.

Userland/Libraries/LibDiff/Format.cpp

@@ -7,6 +7,7 @@
 #include "Format.h"
 #include <AK/String.h>
 #include <AK/StringBuilder.h>
+#include <AK/Vector.h>
 
 namespace Diff {
 String generate_only_additions(const String& text)

Userland/Libraries/LibGfx/BitmapFont.h

@@ -12,6 +12,7 @@
 #include <AK/RefPtr.h>
 #include <AK/String.h>
 #include <AK/Types.h>
+#include <AK/Vector.h>
 #include <LibGfx/Font.h>
 #include <LibGfx/Size.h>
 

Userland/Libraries/LibGfx/Color.cpp

@@ -311,6 +311,30 @@ Optional<Color> Color::from_string(StringView const& string)
     return Color(r.value(), g.value(), b.value(), a.value());
 }
 
+Vector<Color> Color::shades(u32 steps, float max) const
+{
+    float shade = 1.f;
+    float step = max / steps;
+    Vector<Color> shades;
+    for (u32 i = 0; i < steps; i++) {
+        shade -= step;
+        shades.append(this->darkened(shade));
+    }
+    return shades;
+}
+
+Vector<Color> Color::tints(u32 steps, float max) const
+{
+    float shade = 1.f;
+    float step = max / steps;
+    Vector<Color> tints;
+    for (u32 i = 0; i < steps; i++) {
+        shade += step;
+        tints.append(this->lightened(shade));
+    }
+    return tints;
+}
+
 }
 
 bool IPC::encode(IPC::Encoder& encoder, Color const& color)

Userland/Libraries/LibGfx/Color.h

@@ -242,29 +242,8 @@ public:
         return Color(min(255, (int)((float)red() * amount)), min(255, (int)((float)green() * amount)), min(255, (int)((float)blue() * amount)), alpha());
     }
 
-    Vector<Color> shades(u32 steps, float max = 1.f) const
-    {
-        float shade = 1.f;
-        float step = max / steps;
-        Vector<Color> shades;
-        for (u32 i = 0; i < steps; i++) {
-            shade -= step;
-            shades.append(this->darkened(shade));
-        }
-        return shades;
-    }
-
-    Vector<Color> tints(u32 steps, float max = 1.f) const
-    {
-        float shade = 1.f;
-        float step = max / steps;
-        Vector<Color> tints;
-        for (u32 i = 0; i < steps; i++) {
-            shade += step;
-            tints.append(this->lightened(shade));
-        }
-        return tints;
-    }
+    Vector<Color> shades(u32 steps, float max = 1.f) const;
+    Vector<Color> tints(u32 steps, float max = 1.f) const;
 
     constexpr Color inverted() const
     {

Userland/Libraries/LibGfx/Filters/FastBoxBlurFilter.cpp

@@ -4,6 +4,7 @@
  * SPDX-License-Identifier: BSD-2-Clause
  */
 
+#include <AK/Vector.h>
 #include <LibGfx/Filters/FastBoxBlurFilter.h>
 
 namespace Gfx {

Userland/Libraries/LibJS/Runtime/PrivateEnvironment.h

@@ -7,6 +7,7 @@
 #pragma once
 
 #include <AK/FlyString.h>
+#include <AK/Vector.h>
 #include <LibJS/Heap/Cell.h>
 
 namespace JS {

Userland/Libraries/LibWeb/Cookie/ParsedCookie.cpp

@@ -5,6 +5,7 @@
  */
 
 #include "ParsedCookie.h"
+#include <AK/Function.h>
 #include <AK/StdLibExtras.h>
 #include <AK/Vector.h>
 #include <LibIPC/Decoder.h>
@@ -280,12 +281,12 @@ Optional<Core::DateTime> parse_date_time(StringView date_string)
         return to_uint(token, year);
     };
 
-    auto is_delimeter = [](char ch) {
+    Function<bool(char)> is_delimiter = [](char ch) {
         return ch == 0x09 || (ch >= 0x20 && ch <= 0x2f) || (ch >= 0x3b && ch <= 0x40) || (ch >= 0x5b && ch <= 0x60) || (ch >= 0x7b && ch <= 0x7e);
     };
 
     // 1. Using the grammar below, divide the cookie-date into date-tokens.
-    Vector<StringView> date_tokens = date_string.split_view_if(is_delimeter);
+    Vector<StringView> date_tokens = date_string.split_view_if(is_delimiter);
 
     // 2. Process each date-token sequentially in the order the date-tokens appear in the cookie-date.
     bool found_time = false;