RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-06-01 05:48:12 +00:00
Code Issues Activity Actions

Kernel: Try to dispatch pending signals on context switch

Browse source 
This ensures that processes that don't perform any syscalls will also
eventually receive signals.
This commit is contained in:
Idan Horowitz 2022-02-21 19:54:27 +02:00 • committed by Andreas Kling
parent 0911112286
commit 5fa75dbcda
2 changed files with 11 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Kernel/Scheduler.cpp
View file

@ -304,6 +304,11 @@ void Scheduler::context_switch(Thread* thread)
// switched from, and thread reflects Thread::current()
enter_current(*from_thread);
VERIFY(thread == Thread::current());
{
SpinlockLocker lock(thread->get_lock());
thread->dispatch_one_pending_signal();
}
}
void Scheduler::enter_current(Thread& prev_thread)

10
Kernel/Thread.cpp
View file

@ -975,8 +975,6 @@ DispatchSignalResult Thread::dispatch_signal(u8 signal)
return DispatchSignalResult::Deferred;
}
VERIFY(previous_mode() == PreviousMode::UserMode);
auto& action = m_signal_action_data[signal];
// FIXME: Implement SA_SIGINFO signal handlers.
VERIFY(!(action.flags & SA_SIGINFO));
@ -1037,8 +1035,12 @@ DispatchSignalResult Thread::dispatch_signal(u8 signal)
return DispatchSignalResult::Continue;
}
VERIFY(previous_mode() == PreviousMode::UserMode);
VERIFY(current_trap());
if (!current_trap()) {
// We're trying dispatch a signal to a user process that was scheduled after
// a yielding/blocking kernel thread, we don't have a register capture of the
// thread, so just defer processing the signal to later.
return DispatchSignalResult::Deferred;
}
ScopedAddressSpaceSwitcher switcher(m_process);