From 5fd3716e2fbb885e1623aac1f9fea98bd972107a Mon Sep 17 00:00:00 2001 From: MacDue Date: Sun, 5 Jun 2022 13:15:35 +0100 Subject: [PATCH] LibGfx: Fix antialiased circles becoming too pointy at small sizes The issue mentioned in the previous FIXME also applied to circles, I just had not noticed. This is still not a prefect fix rather it just papers over it, but it now seems to render circles correctly. --- Userland/Libraries/LibGfx/AntiAliasingPainter.cpp | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/Userland/Libraries/LibGfx/AntiAliasingPainter.cpp b/Userland/Libraries/LibGfx/AntiAliasingPainter.cpp index 76cb6fd745..80605616fb 100644 --- a/Userland/Libraries/LibGfx/AntiAliasingPainter.cpp +++ b/Userland/Libraries/LibGfx/AntiAliasingPainter.cpp @@ -329,13 +329,10 @@ Gfx::AntiAliasingPainter::Range Gfx::AntiAliasingPainter::draw_ellipse_part( auto correct = [&] { int error = y - y_hat; - if (!is_circle) { - // FIXME: For ellipses the alpha values seem too low, which - // can make them look overly pointy. This fixes that, though there's - // probably a better solution to be found. - // (This issue seems to exist in the base algorithm) - error /= 4; - } + // FIXME: The alpha values seem too low, which makes things look + // overly pointy. This fixes that, though there's probably a better + // solution to be found. (This issue seems to exist in the base algorithm) + error /= 4; delta2_y += error; delta_y += error;