RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-23 13:57:35 +00:00
Code Issues Activity Actions

LibDebug: Miscellaneous fixes from #2097

Browse source
This commit is contained in:
Itamar 2020-05-06 17:22:41 +03:00 • committed by Andreas Kling
parent 42b61cfe2c
commit 5fd64045b1
5 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibDebug/DebugInfo.cpp
View file

@ -186,7 +186,7 @@ NonnullOwnPtr<DebugInfo::VariableInfo> DebugInfo::create_variable_info(const Dwa
if (type_name.has_value()) { if (type_name.has_value()) {
variable_info->type = type_name.value().data.as_string; variable_info->type = type_name.value().data.as_string;
} else { } else {
dbg() << "Unnamed DWRAF type at offset: " << type_die.offset(); dbg() << "Unnamed DWARF type at offset: " << type_die.offset();
variable_info->name = "[Unnamed Type]"; variable_info->name = "[Unnamed Type]";
} }

2
Libraries/LibDebug/DebugInfo.h
View file

@ -68,7 +68,7 @@ public:
struct VariablesScope { struct VariablesScope {
bool is_function { false }; bool is_function { false };
Optional<String> name; String name;
u32 address_low { 0 }; u32 address_low { 0 };
u32 address_high { 0 }; u32 address_high { 0 };
Vector<Dwarf::DIE> dies_of_variables; Vector<Dwarf::DIE> dies_of_variables;

2
Libraries/LibDebug/Dwarf/DIE.h
View file

@ -37,7 +37,7 @@ namespace Dwarf {
class CompilationUnit; class CompilationUnit;
// DIE = Dwarf Information Entry // DIE = Debugging Information Entry
class DIE { class DIE {
public: public:
DIE(const CompilationUnit&, u32 offset); DIE(const CompilationUnit&, u32 offset);

2
Libraries/LibDebug/Dwarf/DwarfInfo.cpp
View file

@ -42,7 +42,7 @@ ByteBuffer DwarfInfo::section_data(const String& section_name)
{ {
auto section = m_elf->image().lookup_section(section_name); auto section = m_elf->image().lookup_section(section_name);
ASSERT(!section.is_undefined()); ASSERT(!section.is_undefined());
return ByteBuffer::wrap(reinterpret_cast<const u8*>(section.raw_data()), section.size()); return section.wrapping_byte_buffer();
} }
void DwarfInfo::populate_compilation_units() void DwarfInfo::populate_compilation_units()

2
Libraries/LibDebug/Dwarf/DwarfInfo.h
View file

@ -38,7 +38,7 @@ namespace Dwarf {
class DwarfInfo : public RefCounted<DwarfInfo> { class DwarfInfo : public RefCounted<DwarfInfo> {
public: public:
static NonnullRefPtr<DwarfInfo> create(NonnullRefPtr<const ELF::Loader> elf) { return adopt(*new DwarfInfo(elf)); } static NonnullRefPtr<DwarfInfo> create(NonnullRefPtr<const ELF::Loader> elf) { return adopt(*new DwarfInfo(move(elf))); }
const ByteBuffer& debug_info_data() const { return m_debug_info_data; } const ByteBuffer& debug_info_data() const { return m_debug_info_data; }
const ByteBuffer& abbreviation_data() const { return m_abbreviation_data; } const ByteBuffer& abbreviation_data() const { return m_abbreviation_data; }