RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 14:02:46 +00:00
Code Issues Activity Actions

Browser: Don't spawn RequestServer and WebSocket in multi-process mode

Browse source 
Single-process Browser forces a connection to these services early on,
to avoid having to unveil their paths. I'm suspicious of the benefits
of this (and the comment about it wasn't even accurate) but let's keep
it for now.

In multi-process mode, there's no need to do this, and in fact it was
causing us to spawn two extra totally unused processes.
This commit is contained in:
Andreas Kling 2021-05-14 17:09:11 +02:00
parent 3ed5a73ede
commit 5fd65adb19
2 changed files with 14 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Userland/Applications/Browser/Tab.cpp
View file

@ -646,13 +646,15 @@ void Tab::update_bookmark_button(const String& url)
void Tab::did_become_active()
{
Web::ResourceLoader::the().on_load_counter_change = [this] {
if (Web::ResourceLoader::the().pending_loads() == 0) {
m_statusbar->set_text("");
return;
}
m_statusbar->set_text(String::formatted("Loading ({} pending resources...)", Web::ResourceLoader::the().pending_loads()));
};
if (m_type == Type::InProcessWebView) {
Web::ResourceLoader::the().on_load_counter_change = [this] {
if (Web::ResourceLoader::the().pending_loads() == 0) {
m_statusbar->set_text("");
return;
}
m_statusbar->set_text(String::formatted("Loading ({} pending resources...)", Web::ResourceLoader::the().pending_loads()));
};
}
BookmarksBarWidget::the().on_bookmark_click = [this](auto& url, unsigned modifiers) {
if (modifiers & Mod_Ctrl)

8
Userland/Applications/Browser/main.cpp
View file

@ -67,9 +67,11 @@ int main(int argc, char** argv)
auto app = GUI::Application::construct(argc, argv);
// Connect to the RequestServer and the WebSocket service immediately so we can drop the "unix" pledge.
Web::ResourceLoader::the();
Web::HTML::WebSocketClientManager::the();
if (Browser::s_single_process) {
// Connect to the RequestServer and the WebSocket service immediately so we don't need to unveil their portals.
Web::ResourceLoader::the();
Web::HTML::WebSocketClientManager::the();
}
// Connect to LaunchServer immediately and let it know that we won't ask for anything other than opening
// the user's downloads directory.