From 601da7e5bd6f70e00eca92ffcd156bcc2d8067e2 Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Tue, 8 Aug 2023 18:23:01 -0400 Subject: [PATCH] Ladybird: Add the select-all action to the JS console Also clarify a comment, because it wasn't immediately clear to me what wouldn't work without the code below it. --- Ladybird/Qt/Tab.cpp | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Ladybird/Qt/Tab.cpp b/Ladybird/Qt/Tab.cpp index 46dc697c39..5a8a8e526d 100644 --- a/Ladybird/Qt/Tab.cpp +++ b/Ladybird/Qt/Tab.cpp @@ -665,12 +665,15 @@ void Tab::show_console_window() m_console_widget->setWindowTitle("JS Console"); m_console_widget->resize(640, 480); - // Make the copy action available in the window via the bound copy key shortcut. - // Simply adding it to the context menu is not enough. + // Make these actions available on the window itself. Adding them to the context menu alone + // does not enable activattion via keyboard shortcuts. m_console_widget->addAction(&m_window->copy_selection_action()); + m_console_widget->addAction(&m_window->select_all_action()); m_console_context_menu = make("Context menu", m_console_widget); m_console_context_menu->addAction(&m_window->copy_selection_action()); + m_console_context_menu->addAction(&m_window->select_all_action()); + m_console_widget->view().on_context_menu_request = [this](Gfx::IntPoint) { auto screen_position = QCursor::pos(); m_console_context_menu->exec(screen_position);