RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-23 15:55:08 +00:00
Code Issues Activity Actions

WindowServer: Fix traversing modal stack

Browse source 
When walking the modal window stack upwards, we need to check if
the top modal window is still a descendant of the window that
the parent is blocked by. Fixes not all windows being brought to
the front when trying to active a parent in the middle of the
modal window stack.
This commit is contained in:
Tom 2020-07-16 09:39:52 -06:00 • committed by Andreas Kling
parent e50874621a
commit 603c17262c
3 changed files with 17 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Services/WindowServer/Window.cpp
View file

@ -634,4 +634,17 @@ void Window::set_progress(int progress)
WindowManager::the().notify_progress_changed(*this);
}
bool Window::is_descendant_of(Window& window) const
{
for (auto* parent = parent_window(); parent; parent = parent->parent_window()) {
if (parent == &window)
return true;
for (auto& accessory : parent->accessory_windows()) {
if (accessory == &window)
return true;
}
}
return false;
}
}