mirror of
https://github.com/RGBCube/serenity
synced 2025-07-26 00:27:43 +00:00
AK+Everywhere: Do not implicitly copy variables in TRY macros
For example, consider cases where we want to propagate errors only in specific instances: auto result = read_data(); // something like ErrorOr<ByteBuffer> if (result.is_error() && result.error().code() != EINTR) continue; auto bytes = TRY(result); The TRY invocation will currently copy the byte buffer when the expression (in this case, just a local variable) is stored into _temporary_result. This patch binds the expression to a reference to prevent such copies. In less trival invocations (such as TRY(some_function()), this will incur only temporary lifetime extensions, i.e. no functional change.
This commit is contained in:
parent
4a916cd379
commit
604d5f5bca
11 changed files with 15 additions and 15 deletions
|
@ -188,7 +188,7 @@ private:
|
|||
// This is a special variant of TRY() that also updates the socket's SO_ERROR field on error.
|
||||
#define SOCKET_TRY(expression) \
|
||||
({ \
|
||||
auto result = (expression); \
|
||||
auto&& result = (expression); \
|
||||
if (result.is_error()) \
|
||||
return set_so_error(result.release_error()); \
|
||||
static_assert(!::AK::Detail::IsLvalueReference<decltype(result.release_value())>, \
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue