RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 22:37:36 +00:00
Code Issues Activity Actions

LibWeb: Remove no-op impl() methods from the WEB_PLATFORM_OBJECT macro

Browse source 
These are leftovers from when wrapper objects still had an internal
implementation, which is no longer the case.
This commit is contained in:
Linus Groh 2022-09-21 17:45:18 +01:00
parent 2cab2a8e8f
commit 6055b0e850
14 changed files with 28 additions and 39 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibWeb/DOM/EventDispatcher.cpp
View file

@ -91,15 +91,14 @@ bool EventDispatcher::inner_invoke(Event& event, Vector<JS::Handle<DOM::DOMEvent
// 8. If global is a Window object, then:
if (is<HTML::Window>(global)) {
auto& bindings_window_global = verify_cast<HTML::Window>(global);
auto& window_impl = bindings_window_global.impl();
auto& window = verify_cast<HTML::Window>(global);
// 1. Set currentEvent to global’s current event.
current_event = window_impl.current_event();
current_event = window.current_event();
// 2. If invocationTargetInShadowTree is false, then set global’s current event to event.
if (!invocation_target_in_shadow_tree)
window_impl.set_current_event(&event);
window.set_current_event(&event);
}
// 9. If listener’s passive is true, then set event’s in passive listener flag.
@ -125,9 +124,8 @@ bool EventDispatcher::inner_invoke(Event& event, Vector<JS::Handle<DOM::DOMEvent
// 12. If global is a Window object, then set global’s current event to currentEvent.
if (is<HTML::Window>(global)) {
auto& bindings_window_global = verify_cast<HTML::Window>(global);
auto& window_impl = bindings_window_global.impl();
window_impl.set_current_event(current_event);
auto& window = verify_cast<HTML::Window>(global);
window.set_current_event(current_event);
}
// 13. If event’s stop immediate propagation flag is set, then return found.

3
Userland/Libraries/LibWeb/DOM/EventTarget.cpp
View file

@ -548,8 +548,7 @@ void EventTarget::activate_event_handler(FlyString const& name, HTML::EventHandl
// The argument must be an object and it must be an Event.
auto event_wrapper_argument = vm.argument(0);
VERIFY(event_wrapper_argument.is_object());
auto& event_wrapper = verify_cast<DOM::Event>(event_wrapper_argument.as_object());
auto& event = event_wrapper.impl();
auto& event = verify_cast<DOM::Event>(event_wrapper_argument.as_object());
TRY(event_target->process_event_handler_for_event(name, event));
return JS::js_undefined();

2
Userland/Libraries/LibWeb/DOM/Range.cpp
View file

@ -43,7 +43,7 @@ JS::NonnullGCPtr<Range> Range::create(Node& start_container, u32 start_offset, N
JS::NonnullGCPtr<Range> Range::create_with_global_object(HTML::Window& window)
{
return Range::create(window.impl());
return Range::create(window);
}
Range::Range(Document& document)