RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 01:37:35 +00:00
Code Issues Activity Actions

LibWeb: Remove no-op impl() methods from the WEB_PLATFORM_OBJECT macro

Browse source 
These are leftovers from when wrapper objects still had an internal
implementation, which is no longer the case.
This commit is contained in:
Linus Groh 2022-09-21 17:45:18 +01:00
parent 2cab2a8e8f
commit 6055b0e850
14 changed files with 28 additions and 39 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/HTML/EventLoop/EventLoop.cpp
View file

@ -247,7 +247,7 @@ void queue_global_task(HTML::Task::Source source, JS::Object& global_object, Fun
DOM::Document* document { nullptr };
if (is<HTML::Window>(global_object)) {
auto& window_object = verify_cast<HTML::Window>(global_object);
document = &window_object.impl().associated_document();
document = &window_object.associated_document();
}
// 3. Queue a task given source, event loop, document, and steps.

4
Userland/Libraries/LibWeb/HTML/Window.cpp
View file

@ -844,7 +844,7 @@ void Window::initialize(JS::Realm& realm)
HTML::Origin Window::origin() const
{
return impl().associated_document().origin();
return associated_document().origin();
}
// https://webidl.spec.whatwg.org/#platform-object-setprototypeof
@ -870,7 +870,7 @@ static JS::ThrowCompletionOr<HTML::Window*> impl_from(JS::VM& vm)
if (!is<Window>(*this_object))
return vm.throw_completion<JS::TypeError>(JS::ErrorType::NotAnObjectOfType, "Window");
return &static_cast<Window*>(this_object)->impl();
return static_cast<Window*>(this_object);
}
JS_DEFINE_NATIVE_FUNCTION(Window::alert)

2
Userland/Libraries/LibWeb/HTML/Worker.h
View file

@ -39,7 +39,7 @@ public:
static DOM::ExceptionOr<JS::NonnullGCPtr<Worker>> create(FlyString const& script_url, WorkerOptions const options, DOM::Document& document);
static DOM::ExceptionOr<JS::NonnullGCPtr<Worker>> create_with_global_object(HTML::Window& window, FlyString const& script_url, WorkerOptions const options)
{
return Worker::create(script_url, options, window.impl().associated_document());
return Worker::create(script_url, options, window.associated_document());
}
DOM::ExceptionOr<void> terminate();