RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 02:27:43 +00:00
Code Issues Activity Actions

LibWeb/HTML: Port Window.getSelection() to IDL

Browse source
This commit is contained in:
Linus Groh 2023-03-06 22:34:48 +00:00
parent 56550b6ec0
commit 606b9ff6f3
5 changed files with 18 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Userland/Libraries/LibWeb/DOM/Document.cpp
View file

@ -320,6 +320,8 @@ JS::ThrowCompletionOr<void> Document::initialize(JS::Realm& realm)
MUST_OR_THROW_OOM(Base::initialize(realm));
set_prototype(&Bindings::ensure_web_prototype<Bindings::DocumentPrototype>(realm, "Document"));
m_selection = MUST_OR_THROW_OOM(heap().allocate<Selection::Selection>(realm, realm, *this));
return {};
}
@ -369,17 +371,12 @@ void Document::visit_edges(Cell::Visitor& visitor)
}
// https://w3c.github.io/selection-api/#dom-document-getselection
JS::GCPtr<Selection::Selection> Document::get_selection()
JS::GCPtr<Selection::Selection> Document::get_selection() const
{
// The method must return the selection associated with this if this has an associated browsing context,
// and it must return null otherwise.
if (!browsing_context()) {
return nullptr;
}
if (!m_selection) {
m_selection = Selection::Selection::create(realm(), *this).release_value_but_fixme_should_propagate_errors();
}
if (!browsing_context())
return {};
return m_selection;
}

3
Userland/Libraries/LibWeb/DOM/Document.h
View file

@ -88,8 +88,7 @@ public:
static WebIDL::ExceptionOr<JS::NonnullGCPtr<Document>> construct_impl(JS::Realm&);
virtual ~Document() override;
// https://w3c.github.io/selection-api/#dom-document-getselection
JS::GCPtr<Selection::Selection> get_selection();
JS::GCPtr<Selection::Selection> get_selection() const;
size_t next_layout_node_serial_id(Badge<Layout::Node>) { return m_next_layout_node_serial_id++; }
size_t layout_node_count() const { return m_next_layout_node_serial_id; }