RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 04:27:44 +00:00
Code Issues Activity Actions

LibGUI: Don't ask WindowServer to destroy windows during app teardown

Browse source 
This makes teardown faster since we don't have to wait for responses to
each destroy_window request. It also avoids doing IPC during teardown,
which is a general source of problems.
This commit is contained in:
Andreas Kling 2021-11-03 19:54:22 +01:00
parent 24ea6a8ce7
commit 60a245b065
1 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibGUI/Window.cpp
View file

@ -198,6 +198,12 @@ void Window::hide()
{ {
if (!is_visible()) if (!is_visible())
return; return;
// NOTE: Don't bother asking WindowServer to destroy windows during application teardown.
// All our windows will be automatically garbage-collected by WindowServer anyway.
if (GUI::Application::in_teardown())
return;
auto destroyed_window_ids = WindowServerConnection::the().destroy_window(m_window_id); auto destroyed_window_ids = WindowServerConnection::the().destroy_window(m_window_id);
server_did_destroy(); server_did_destroy();