RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 20:37:36 +00:00
Code Issues Activity Actions

LibJS/Bytecode: Make NewPrimitiveArray a variable-length instruction

Browse source 
Instead of having a FixedArray with a separate heap allocation, we can
just bake the primitive values into the instruction itself.
This commit is contained in:
Andreas Kling 2024-03-03 12:37:28 +01:00
parent 5813df21c8
commit 60a555e364
4 changed files with 44 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Userland/Libraries/LibJS/Bytecode/Op.h
View file

@ -290,22 +290,30 @@ private:
class NewPrimitiveArray final : public Instruction {
public:
NewPrimitiveArray(Operand dst, FixedArray<Value> values)
: Instruction(Type::NewPrimitiveArray, sizeof(*this))
NewPrimitiveArray(Operand dst, ReadonlySpan<Value> elements)
: Instruction(Type::NewPrimitiveArray, length_impl(elements.size()))
, m_dst(dst)
, m_values(move(values))
, m_element_count(elements.size())
{
for (size_t i = 0; i < m_element_count; ++i)
m_elements[i] = elements[i];
}
size_t length_impl(size_t element_count) const
{
return round_up_to_power_of_two(alignof(void*), sizeof(*this) + sizeof(Value) * element_count);
}
ThrowCompletionOr<void> execute_impl(Bytecode::Interpreter&) const;
ByteString to_byte_string_impl(Bytecode::Executable const&) const;
Operand dst() const { return m_dst; }
ReadonlySpan<Value> values() const { return m_values.span(); }
ReadonlySpan<Value> elements() const { return { m_elements, m_element_count }; }
private:
Operand m_dst;
FixedArray<Value> m_values;
size_t m_element_count { 0 };
Value m_elements[];
};
class ArrayAppend final : public Instruction {