RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-14 09:04:59 +00:00
Code Issues Activity Actions

Userland: Convert command line arguments to String/StringView

Browse source 
StringView was used where possible. Some utilities still use libc
functions which expect null-terminated strings, so String objects were
used there instead.
This commit is contained in:
sin-ack 2022-07-11 20:42:03 +00:00 • committed by Andreas Kling
parent fded8f861d
commit 60f6bc902b
25 changed files with 101 additions and 100 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Utilities/notify.cpp
View file

@ -15,9 +15,9 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
auto app = TRY(GUI::Application::try_create(arguments));
Core::ArgsParser args_parser;
char const* title = nullptr;
char const* message = nullptr;
char const* icon_path = nullptr;
StringView title {};
StringView message {};
StringView icon_path {};
args_parser.add_positional_argument(title, "Title of the notification", "title");
args_parser.add_positional_argument(message, "Message to display in the notification", "message");
args_parser.add_positional_argument(icon_path, "Path of icon to display in the notification", "icon-path", Core::ArgsParser::Required::No);
@ -26,7 +26,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
auto notification = TRY(GUI::Notification::try_create());
notification->set_text(message);
notification->set_title(title);
if (icon_path) {
if (!icon_path.is_empty()) {
notification->set_icon(TRY(Gfx::Bitmap::try_load_from_file(icon_path)));
}
notification->show();