RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-14 09:24:57 +00:00
Code Issues Activity Actions

Userland: Convert command line arguments to String/StringView

Browse source 
StringView was used where possible. Some utilities still use libc
functions which expect null-terminated strings, so String objects were
used there instead.
This commit is contained in:
sin-ack 2022-07-11 20:42:03 +00:00 • committed by Andreas Kling
parent fded8f861d
commit 60f6bc902b
25 changed files with 101 additions and 100 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Utilities/passwd.cpp
View file

@ -30,7 +30,8 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
bool del = false;
bool lock = false;
bool unlock = false;
char const* username = nullptr;
// FIXME: Replace with StringView once Core::Account::from_name stops taking a char const*.
String username {};
auto args_parser = Core::ArgsParser();
args_parser.set_general_help("Modify an account password.");
@ -44,8 +45,8 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
uid_t current_uid = getuid();
// target_account is the account we are changing the password of.
auto target_account = TRY((username)
? Core::Account::from_name(username)
auto target_account = TRY(!username.is_empty()
? Core::Account::from_name(username.characters())
: Core::Account::from_uid(current_uid));
setpwent();