RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-28 08:55:06 +00:00
Code Issues Activity Actions

Kernel: Drop the "helper" region after ELF load is finished.

Browse source 
The individual segment mappings will keep the VMObject alive.
This commit is contained in:
Andreas Kling 2019-02-10 12:42:54 +01:00
parent d333013a54
commit 6103e374cc
1 changed files with 1 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/Process.cpp
View file

@ -316,7 +316,7 @@ int Process::do_exec(const String& path, Vector<String>&& arguments, Vector<Stri
auto vmo = VMObject::create_file_backed(descriptor->inode()); auto vmo = VMObject::create_file_backed(descriptor->inode());
vmo->set_name(descriptor->absolute_path()); vmo->set_name(descriptor->absolute_path());
RetainPtr<Region> region = allocate_region_with_vmo(LinearAddress(), descriptor->metadata().size, vmo.copy_ref(), 0, "helper", true, false); RetainPtr<Region> region = allocate_region_with_vmo(LinearAddress(), descriptor->metadata().size, vmo.copy_ref(), 0, "executable", true, false);
// FIXME: Should we consider doing on-demand paging here? Is it actually useful? // FIXME: Should we consider doing on-demand paging here? Is it actually useful?
bool success = region->page_in(); bool success = region->page_in();
@ -362,8 +362,6 @@ int Process::do_exec(const String& path, Vector<String>&& arguments, Vector<Stri
} }
} }
m_regions.append(move(region));
m_signal_stack_kernel_region = nullptr; m_signal_stack_kernel_region = nullptr;
m_signal_stack_user_region = nullptr; m_signal_stack_user_region = nullptr;
m_display_framebuffer_region = nullptr; m_display_framebuffer_region = nullptr;