RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 11:52:44 +00:00
Code Issues Activity Actions

LibWeb: Don't prune whitespace nodes from layout tree

Browse source 
Various whitespace-related issues have been fixed, and support for the
different CSS white-space values is improved enough that I think we can
stop doing the hack where we just prune whitespace nodes from the tree
and actually let them show up.

This is a nice step forward for correctness with the slight downside of
cluttering up layout tree dumps with tons of whitespace text nodes.
But hey, that's the web we know & love. :^)

Fixes #4427.
This commit is contained in:
Andreas Kling 2021-01-06 14:48:54 +01:00
parent 29a4da30b7
commit 612827eff3
3 changed files with 0 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Libraries/LibWeb/Layout/TextNode.cpp
View file

@ -57,21 +57,6 @@ static bool is_all_whitespace(const StringView& string)
return true;
}
const String& TextNode::text_for_style(const CSS::StyleProperties& style) const
{
static String one_space = " ";
if (is_all_whitespace(dom_node().data())) {
switch (style.white_space().value_or(CSS::WhiteSpace::Normal)) {
case CSS::WhiteSpace::Pre:
case CSS::WhiteSpace::PreWrap:
break;
default:
return one_space;
}
}
return dom_node().data();
}
void TextNode::paint_fragment(PaintContext& context, const LineBoxFragment& fragment, PaintPhase phase) const
{
auto& painter = context.painter();