RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:37:35 +00:00
Code Issues Activity Actions

FileManager: Check for write permission before enabling certain actions

Browse source 
Upon DirectoryView selection change, check for write permission before
enabling delete and cut. This disallows attempting to delete/cut and
paste a file that you don't have write permission to by using keybinds.

Fixes #13983.
This commit is contained in:
offtkp 2022-05-09 22:00:26 +03:00 • committed by Linus Groh
parent 67c8adb561
commit 61a9ad45ed
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Applications/FileManager/main.cpp
View file

@ -1107,10 +1107,10 @@ ErrorOr<int> run_in_windowed_mode(String const& initial_location, String const&
directory_view->on_selection_change = [&](GUI::AbstractView& view) { directory_view->on_selection_change = [&](GUI::AbstractView& view) {
auto& selection = view.selection(); auto& selection = view.selection();
cut_action->set_enabled(!selection.is_empty()); cut_action->set_enabled(!selection.is_empty() && access(directory_view->path().characters(), W_OK) == 0);
copy_action->set_enabled(!selection.is_empty()); copy_action->set_enabled(!selection.is_empty());
focus_dependent_delete_action->set_enabled((!tree_view.selection().is_empty() && tree_view.is_focused()) focus_dependent_delete_action->set_enabled((!tree_view.selection().is_empty() && tree_view.is_focused())
|| !directory_view->current_view().selection().is_empty()); || (!directory_view->current_view().selection().is_empty() && access(directory_view->path().characters(), W_OK) == 0));
}; };
auto directory_open_action = GUI::Action::create("Open", Gfx::Bitmap::try_load_from_file("/res/icons/16x16/open.png").release_value_but_fixme_should_propagate_errors(), [&](auto&) { auto directory_open_action = GUI::Action::create("Open", Gfx::Bitmap::try_load_from_file("/res/icons/16x16/open.png").release_value_but_fixme_should_propagate_errors(), [&](auto&) {