From 62092a329df25a99bd8887c59598198f31f1c215 Mon Sep 17 00:00:00 2001 From: Jelle Raaijmakers Date: Tue, 3 Jan 2023 16:55:40 +0100 Subject: [PATCH] LibGL: Make `GLsizeiptr` signed The Khronos description of a "non-negative binary integer" does not mean an unsigned type, just that it should not be negative. --- Userland/Libraries/LibGL/Buffer.cpp | 2 +- Userland/Libraries/LibGL/GL/glplatform.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Userland/Libraries/LibGL/Buffer.cpp b/Userland/Libraries/LibGL/Buffer.cpp index 4b8ceacb1f..e44bff386c 100644 --- a/Userland/Libraries/LibGL/Buffer.cpp +++ b/Userland/Libraries/LibGL/Buffer.cpp @@ -61,7 +61,7 @@ void GLContext::gl_buffer_sub_data(GLenum target, GLintptr offset, GLsizeiptr si auto& target_buffer = target == GL_ELEMENT_ARRAY_BUFFER ? m_element_array_buffer : m_array_buffer; RETURN_WITH_ERROR_IF(!target_buffer, GL_INVALID_OPERATION); - RETURN_WITH_ERROR_IF((offset + size) > target_buffer->size(), GL_INVALID_VALUE); + RETURN_WITH_ERROR_IF(static_cast(offset + size) > target_buffer->size(), GL_INVALID_VALUE); target_buffer->replace_data(data, offset, size); } diff --git a/Userland/Libraries/LibGL/GL/glplatform.h b/Userland/Libraries/LibGL/GL/glplatform.h index e57f6edd4c..824a367105 100644 --- a/Userland/Libraries/LibGL/GL/glplatform.h +++ b/Userland/Libraries/LibGL/GL/glplatform.h @@ -32,7 +32,7 @@ typedef long GLintptr; typedef unsigned int GLuint; typedef int GLfixed; typedef int GLsizei; -typedef unsigned long GLsizeiptr; +typedef long GLsizeiptr; typedef void GLvoid; typedef float GLfloat; typedef double GLclampd;