RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 19:57:45 +00:00
Code Issues Activity Actions

LibJS: Remove "uprooting" mechanism from garbage collector

Browse source 
The Heap::uproot_cell() API was used to implement markAsGarbage() which
was used in 3 tests to forcibly destroy a value, even if it had
references on the stack or elsewhere.

This patch rewrites the 3 tests that used this mechanism to be
structured in a way that allows garbage collection to collect the values
as intended without hacks. And now that the uprooting mechanism is no
longer needed, it's uprooted as well.

This fixes 3 test-js tests in bytecode mode. :^)
This commit is contained in:
Andreas Kling 2023-07-21 10:09:22 +02:00
parent 9054b1bc14
commit 6232ad3a0d
6 changed files with 28 additions and 65 deletions
Download patch file Download diff file Expand all files Collapse all files

25
Userland/Libraries/LibJS/Tests/builtins/WeakMap/WeakMap.prototype.set.js
View file

@ -1,3 +1,9 @@
function registerInDifferentScope(registry) {
const target = {};
registry.register(target, {});
eval("");
}
test("basic functionality", () => {
expect(WeakMap.prototype.set).toHaveLength(2);
@ -21,25 +27,26 @@ test("invalid values", () => {
});
});
function setObjectKey(weakMap) {
expect(weakMap.set({ e: 3 }, 1)).toBe(weakMap);
}
function setSymbolKey(weakMap) {
expect(weakMap.set(Symbol("foo"), "bar")).toBe(weakMap);
}
test("automatic removal of garbage-collected values", () => {
const weakMap = new WeakMap();
const objectKey = { e: 3 };
expect(weakMap.set(objectKey, 1)).toBe(weakMap);
setObjectKey(weakMap);
expect(getWeakMapSize(weakMap)).toBe(1);
markAsGarbage("objectKey");
gc();
expect(getWeakMapSize(weakMap)).toBe(0);
const symbolKey = Symbol("foo");
expect(weakMap.set(symbolKey, "bar")).toBe(weakMap);
setSymbolKey(weakMap);
expect(getWeakMapSize(weakMap)).toBe(1);
markAsGarbage("symbolKey");
gc();
expect(getWeakMapSize(weakMap)).toBe(0);
});