mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 02:47:35 +00:00
LibJS: Remove "uprooting" mechanism from garbage collector
The Heap::uproot_cell() API was used to implement markAsGarbage() which was used in 3 tests to forcibly destroy a value, even if it had references on the stack or elsewhere. This patch rewrites the 3 tests that used this mechanism to be structured in a way that allows garbage collection to collect the values as intended without hacks. And now that the uprooting mechanism is no longer needed, it's uprooted as well. This fixes 3 test-js tests in bytecode mode. :^)
This commit is contained in:
parent
9054b1bc14
commit
6232ad3a0d
6 changed files with 28 additions and 65 deletions
|
@ -16,25 +16,26 @@ test("invalid values", () => {
|
|||
});
|
||||
});
|
||||
|
||||
function addObjectItem(weakSet) {
|
||||
weakSet.add({ a: 1 });
|
||||
}
|
||||
|
||||
function addSymbolItem(weakSet) {
|
||||
weakSet.add(Symbol("foo"));
|
||||
}
|
||||
|
||||
test("automatic removal of garbage-collected values", () => {
|
||||
const weakSet = new WeakSet();
|
||||
const objectItem = { a: 1 };
|
||||
|
||||
expect(weakSet.add(objectItem)).toBe(weakSet);
|
||||
addObjectItem(weakSet);
|
||||
expect(getWeakSetSize(weakSet)).toBe(1);
|
||||
|
||||
markAsGarbage("objectItem");
|
||||
gc();
|
||||
|
||||
expect(getWeakSetSize(weakSet)).toBe(0);
|
||||
|
||||
const symbolItem = Symbol("foo");
|
||||
|
||||
expect(weakSet.add(symbolItem)).toBe(weakSet);
|
||||
addSymbolItem(weakSet);
|
||||
expect(getWeakSetSize(weakSet)).toBe(1);
|
||||
|
||||
markAsGarbage("symbolItem");
|
||||
gc();
|
||||
|
||||
expect(getWeakSetSize(weakSet)).toBe(0);
|
||||
});
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue