RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 15:37:46 +00:00
Code Issues Activity Actions

LibRegex: Allow quantifiers after quantifiable assertions

Browse source 
While quantifying assertions is very much meaningless, the specification
allows them with annex B's extended grammar for browsers, so read and
apply the quantifiers.
Fixes #12373.
This commit is contained in:
Ali Mohammad Pur 2022-02-19 17:18:23 +03:30 • committed by Andreas Kling
parent 6a1ae4c185
commit 627bbee055
2 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibRegex/Regex.cpp
View file

@ -599,6 +599,7 @@ TEST_CASE(ECMA262_parse)
{ "(?<$$_$$>a)"sv }, { "(?<$$_$$>a)"sv },
{ "(?<ÿ>a)"sv }, { "(?<ÿ>a)"sv },
{ "(?<𝓑𝓻𝓸𝔀𝓷>a)"sv }, { "(?<𝓑𝓻𝓸𝔀𝓷>a)"sv },
{ "((?=lg)?[vl]k\\-?\\d{3}) bui| 3\\.[-\\w; ]{10}lg?-([06cv9]{3,4})"sv, regex::Error::NoError, ECMAScriptFlags::BrowserExtended } // #12373, quantifiable assertions.
}; };
for (auto& test : tests) { for (auto& test : tests) {

3
Userland/Libraries/LibRegex/RegexParser.cpp
View file

@ -1083,6 +1083,9 @@ bool ECMA262Parser::parse_assertion(ByteCode& stack, [[maybe_unused]] size_t& ma
if (m_should_use_browser_extended_grammar) { if (m_should_use_browser_extended_grammar) {
if (!unicode) { if (!unicode) {
if (parse_quantifiable_assertion(assertion_stack, match_length_minimum, named)) { if (parse_quantifiable_assertion(assertion_stack, match_length_minimum, named)) {
if (!parse_quantifier(assertion_stack, match_length_minimum, unicode, named))
return false;
stack.extend(move(assertion_stack)); stack.extend(move(assertion_stack));
return true; return true;
} }