RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-02 20:12:13 +00:00
Code Issues Activity Actions

LibWeb: Remove unecessary dependence on Window from Geometry classes

Browse source 
These classes only needed Window to get at its realm. Pass a realm
directly to construct Geometry classes.
This commit is contained in:
Andrew Kaster 2022-09-25 18:03:02 -06:00 • committed by Linus Groh
parent f0c5f77f99
commit 62a8c26b73
11 changed files with 51 additions and 44 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Userland/Libraries/LibWeb/Geometry/DOMRect.cpp
View file

@ -4,25 +4,25 @@
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <LibWeb/Bindings/Intrinsics.h>
#include <LibWeb/Geometry/DOMRect.h>
#include <LibWeb/HTML/Window.h>
namespace Web::Geometry {
JS::NonnullGCPtr<DOMRect> DOMRect::create_with_global_object(HTML::Window& window, double x, double y, double width, double height)
JS::NonnullGCPtr<DOMRect> DOMRect::construct_impl(JS::Realm& realm, double x, double y, double width, double height)
{
return *window.heap().allocate<DOMRect>(window.realm(), window, x, y, width, height);
return *realm.heap().allocate<DOMRect>(realm, realm, x, y, width, height);
}
JS::NonnullGCPtr<DOMRect> DOMRect::create(HTML::Window& window, Gfx::FloatRect const& rect)
JS::NonnullGCPtr<DOMRect> DOMRect::create(JS::Realm& realm, Gfx::FloatRect const& rect)
{
return create_with_global_object(window, rect.x(), rect.y(), rect.width(), rect.height());
return construct_impl(realm, rect.x(), rect.y(), rect.width(), rect.height());
}
DOMRect::DOMRect(HTML::Window& window, double x, double y, double width, double height)
: DOMRectReadOnly(window, x, y, width, height)
DOMRect::DOMRect(JS::Realm& realm, double x, double y, double width, double height)
: DOMRectReadOnly(realm, x, y, width, height)
{
set_prototype(&window.cached_web_prototype("DOMRect"));
set_prototype(&Bindings::cached_web_prototype(realm, "DOMRect"));
}
DOMRect::~DOMRect() = default;