RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 00:37:35 +00:00
Code Issues Activity Actions

LibJS+LibWeb: Move exception logging and remove should_log_exceptions

Browse source 
LibWeb is now responsible for logging unhandled exceptions itself,
which means set_should_log_exceptions() is no longer used and can be
removed. It turned out to be not the best option for web page exception
logging, as we would have no indication regarding whether the exception
was later handled of not.
This commit is contained in:
Linus Groh 2021-04-24 18:25:05 +02:00 • committed by Andreas Kling
parent 08373090ae
commit 62c7608a25
4 changed files with 26 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibJS/Runtime/VM.h
View file

@ -54,9 +54,6 @@ public:
static NonnullRefPtr<VM> create();
~VM();
bool should_log_exceptions() const { return m_should_log_exceptions; }
void set_should_log_exceptions(bool b) { m_should_log_exceptions = b; }
Heap& heap() { return m_heap; }
const Heap& heap() const { return m_heap; }
@ -271,7 +268,6 @@ private:
Shape* m_scope_object_shape { nullptr };
bool m_underscore_is_last_value { false };
bool m_should_log_exceptions { false };
};
template<>