RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 07:17:35 +00:00
Code Issues Activity Actions

LibCore: Fix memory leak in Core::Process::spawn()

Browse source 
Previously the spawn_actions were not destroyed, which leaked a
little memory.
This commit is contained in:
MacDue 2023-03-13 20:24:33 +00:00 • committed by Linus Groh
parent d0ac24ddbf
commit 62e8360dcf
1 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibCore/Process.cpp
View file

@ -1,12 +1,13 @@
/* /*
* Copyright (c) 2021, Andreas Kling <kling@serenityos.org> * Copyright (c) 2021, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, MacDue <macdue@dueutil.tech> * Copyright (c) 2022-2023, MacDue <macdue@dueutil.tech>
* Copyright (c) 2023, Sam Atkins <atkinssj@serenityos.org> * Copyright (c) 2023, Sam Atkins <atkinssj@serenityos.org>
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
#include <AK/DeprecatedString.h> #include <AK/DeprecatedString.h>
#include <AK/ScopeGuard.h>
#include <AK/String.h> #include <AK/String.h>
#include <AK/Vector.h> #include <AK/Vector.h>
#include <LibCore/Process.h> #include <LibCore/Process.h>
@ -58,6 +59,9 @@ struct ArgvList {
#ifdef AK_OS_SERENITY #ifdef AK_OS_SERENITY
posix_spawn_file_actions_t spawn_actions; posix_spawn_file_actions_t spawn_actions;
posix_spawn_file_actions_init(&spawn_actions); posix_spawn_file_actions_init(&spawn_actions);
ScopeGuard cleanup_spawn_actions = [&] {
posix_spawn_file_actions_destroy(&spawn_actions);
};
if (!m_working_directory.is_empty()) if (!m_working_directory.is_empty())
posix_spawn_file_actions_addchdir(&spawn_actions, m_working_directory.characters()); posix_spawn_file_actions_addchdir(&spawn_actions, m_working_directory.characters());