RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-02 23:42:13 +00:00
Code Issues Activity Actions

LibWeb: Remove some unnecessary throwaway strings in the CSS parser

Browse source 
We've had StringView::ends_with(..., CaseSensitivity) for a while,
so let's use it to avoid creating a bunch of unnecessary strings here.
This commit is contained in:
Andreas Kling 2020-08-07 20:33:03 +02:00
parent 498845ea2f
commit 62ec42c112
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Libraries/LibWeb/CSS/Parser/CSSParser.cpp
View file

@ -272,19 +272,19 @@ static CSS::Length parse_length(const CSS::ParsingContext& context, const String
if (view.ends_with('%')) { if (view.ends_with('%')) {
type = CSS::Length::Type::Percentage; type = CSS::Length::Type::Percentage;
value = try_parse_float(view.substring_view(0, view.length() - 1)); value = try_parse_float(view.substring_view(0, view.length() - 1));
} else if (view.to_string().to_lowercase().ends_with("px")) { } else if (view.ends_with("px", CaseSensitivity::CaseInsensitive)) {
type = CSS::Length::Type::Px; type = CSS::Length::Type::Px;
value = try_parse_float(view.substring_view(0, view.length() - 2)); value = try_parse_float(view.substring_view(0, view.length() - 2));
} else if (view.to_string().to_lowercase().ends_with("pt")) { } else if (view.ends_with("pt", CaseSensitivity::CaseInsensitive)) {
type = CSS::Length::Type::Pt; type = CSS::Length::Type::Pt;
value = try_parse_float(view.substring_view(0, view.length() - 2)); value = try_parse_float(view.substring_view(0, view.length() - 2));
} else if (view.to_string().to_lowercase().ends_with("rem")) { } else if (view.ends_with("rem", CaseSensitivity::CaseInsensitive)) {
type = CSS::Length::Type::Rem; type = CSS::Length::Type::Rem;
value = try_parse_float(view.substring_view(0, view.length() - 3)); value = try_parse_float(view.substring_view(0, view.length() - 3));
} else if (view.to_string().to_lowercase().ends_with("em")) { } else if (view.ends_with("em", CaseSensitivity::CaseInsensitive)) {
type = CSS::Length::Type::Em; type = CSS::Length::Type::Em;
value = try_parse_float(view.substring_view(0, view.length() - 2)); value = try_parse_float(view.substring_view(0, view.length() - 2));
} else if (view.to_string().to_lowercase().ends_with("ex")) { } else if (view.ends_with("ex", CaseSensitivity::CaseInsensitive)) {
type = CSS::Length::Type::Ex; type = CSS::Length::Type::Ex;
value = try_parse_float(view.substring_view(0, view.length() - 2)); value = try_parse_float(view.substring_view(0, view.length() - 2));
} else if (view == "0") { } else if (view == "0") {