RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-10 04:07:35 +00:00
Code Issues Activity Actions

Kernel: Make Inode::read_entire() return a KBuffer (not ByteBuffer)

Browse source 
ByteBuffer is backed by kmalloc heap memory which is a scarce resource.
This fixes an OOM panic when traversing a large directory.
This commit is contained in:
Andreas Kling 2020-08-11 19:47:24 +02:00
parent ec93d6ffdc
commit 62ec6e5fe0
7 changed files with 12 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/FileSystem/Inode.h
View file

@ -67,7 +67,7 @@ public:
InodeIdentifier identifier() const { return { fsid(), index() }; }
virtual InodeMetadata metadata() const = 0;
KResultOr<ByteBuffer> read_entire(FileDescription* = nullptr) const;
KResultOr<KBuffer> read_entire(FileDescription* = nullptr) const;
virtual ssize_t read_bytes(off_t, ssize_t, u8* buffer, FileDescription*) const = 0;
virtual KResult traverse_as_directory(Function<bool(const FS::DirectoryEntry&)>) const = 0;