RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 21:17:45 +00:00
Code Issues Activity Actions

LibWeb: Better handling of floating boxes from inline formatting context

Browse source 
Handle the clear property for floating boxes and add tracking for
vertical clearence within an inline formatting context.
This commit is contained in:
Andi Gallo 2023-07-29 04:05:45 +00:00 • committed by Andreas Kling
parent fd86509ef8
commit 62f15f94d2
9 changed files with 78 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

23
Tests/LibWeb/Layout/expected/block-and-inline/clear-both-from-inline-formatting-context.txt Normal file
View file

@ -0,0 +1,23 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x0 children: not-inline
BlockContainer <div> at (8,8) content-size 784x0 children: inline
TextNode <#text>
BlockContainer <h1.left> at (8,29.4375) content-size 28.53125x34.9375 floating [BFC] children: inline
line 0 width: 28.53125, height: 34.9375, bottom: 34.9375, baseline: 27.0625
frag 0 from TextNode start: 0, length: 1, rect: [8,29.4375 28.53125x34.9375]
"A"
TextNode <#text>
TextNode <#text>
BlockContainer <h1.right> at (773.3125,29.4375) content-size 18.6875x34.9375 floating [BFC] children: inline
line 0 width: 18.6875, height: 34.9375, bottom: 34.9375, baseline: 27.0625
frag 0 from TextNode start: 0, length: 1, rect: [773.3125,29.4375 18.6875x34.9375]
"B"
TextNode <#text>
TextNode <#text>
BlockContainer <div.c> at (8,155.8125) content-size 11.5625x17.46875 floating [BFC] children: inline
line 0 width: 11.5625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [8,155.8125 11.5625x17.46875]
"X"
TextNode <#text>
TextNode <#text>

0
Tests/LibWeb/Layout/expected/block-and-inline/float-vertical-intersection-with-margin.txt → Tests/LibWeb/Layout/expected/block-and-inline/float-clear-by-line-break.txt
View file

21
Tests/LibWeb/Layout/input/block-and-inline/clear-both-from-inline-formatting-context.html Normal file
View file

@ -0,0 +1,21 @@
<style>
.left {
float: left;
}
.right {
float: right;
}
.c {
margin-top: 70px;
clear: both;
float: left;
}
</style>
<div>
<h1 class="left">A</h1>
<h1 class="right">B</h1>
<div class="c">X</div>
</div>

1
Tests/LibWeb/Layout/input/block-and-inline/float-vertical-intersection-with-margin.html → Tests/LibWeb/Layout/input/block-and-inline/float-clear-by-line-break.html
View file

@ -2,7 +2,6 @@
.a {
float: left;
width: 100px;
margin-bottom: 4px;
}
br {