RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 10:18:11 +00:00
Code Issues Activity Actions

LibWeb: Port HTMLObjectElement interface from DeprecatedString to String

Browse source
This commit is contained in:
Shannon Booth 2023-09-03 15:39:01 +12:00 • committed by Tim Flynn
parent de07fb5132
commit 63aa93aaf4
3 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/HTML/HTMLObjectElement.cpp
View file

@ -67,10 +67,10 @@ void HTMLObjectElement::attribute_changed(DeprecatedFlyString const& name, Depre
} }
// https://html.spec.whatwg.org/multipage/iframe-embed-object.html#attr-object-data // https://html.spec.whatwg.org/multipage/iframe-embed-object.html#attr-object-data
DeprecatedString HTMLObjectElement::data() const String HTMLObjectElement::data() const
{ {
auto data = deprecated_attribute(HTML::AttributeNames::data); auto data = deprecated_attribute(HTML::AttributeNames::data);
return document().parse_url(data).to_deprecated_string(); return MUST(document().parse_url(data).to_string());
} }
JS::GCPtr<Layout::Node> HTMLObjectElement::create_layout_node(NonnullRefPtr<CSS::StyleProperties> style) JS::GCPtr<Layout::Node> HTMLObjectElement::create_layout_node(NonnullRefPtr<CSS::StyleProperties> style)

4
Userland/Libraries/LibWeb/HTML/HTMLObjectElement.h
View file

@ -36,8 +36,8 @@ public:
virtual void attribute_changed(DeprecatedFlyString const& name, DeprecatedString const& value) override; virtual void attribute_changed(DeprecatedFlyString const& name, DeprecatedString const& value) override;
DeprecatedString data() const; String data() const;
void set_data(DeprecatedString const& data) { MUST(set_attribute(HTML::AttributeNames::data, data)); } void set_data(String const& data) { MUST(set_attribute(HTML::AttributeNames::data, data)); }
DeprecatedString type() const { return deprecated_attribute(HTML::AttributeNames::type); } DeprecatedString type() const { return deprecated_attribute(HTML::AttributeNames::type); }

2
Userland/Libraries/LibWeb/HTML/HTMLObjectElement.idl
View file

@ -2,7 +2,7 @@
#import <HTML/HTMLElement.idl> #import <HTML/HTMLElement.idl>
// https://html.spec.whatwg.org/multipage/iframe-embed-object.html#htmlobjectelement // https://html.spec.whatwg.org/multipage/iframe-embed-object.html#htmlobjectelement
[Exposed=Window, UseDeprecatedAKString] [Exposed=Window]
interface HTMLObjectElement : HTMLElement { interface HTMLObjectElement : HTMLElement {
[HTMLConstructor] constructor(); [HTMLConstructor] constructor();