RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-23 12:05:07 +00:00
Code Issues Activity Actions

LibJS: Pass "this" as an Object* to NativeFunction callbacks

Browse source 
Instead of every NativeFunction callback having to ask the Interpreter
for the current "this" value and then converting it to an Object etc,
just pass "this" as an Object* directly.
This commit is contained in:
Andreas Kling 2020-03-15 20:51:36 +01:00
parent 3163929990
commit 63b3cfdc73
9 changed files with 28 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

22
Libraries/LibJS/StringPrototype.cpp
View file

@ -34,25 +34,27 @@
namespace JS {
StringPrototype::StringPrototype()
{
put_native_property(
"length", [](Object* object) {
ASSERT(object->is_string_object());
return Value((i32) static_cast<const StringObject*>(object)->primitive_string()->string().length());
"length", [](Object* this_object) {
ASSERT(this_object);
ASSERT(this_object->is_string_object());
return Value((i32) static_cast<const StringObject*>(this_object)->primitive_string()->string().length());
},
nullptr);
put_native_function("charAt", [](Interpreter& interpreter, Vector<Value> arguments) -> Value {
put_native_function("charAt", [](Object* this_object, Vector<Value> arguments) -> Value {
ASSERT(this_object);
i32 index = 0;
if (!arguments.is_empty())
index = arguments[0].to_i32();
Value this_value = interpreter.this_value();
ASSERT(this_value.is_object());
ASSERT(this_value.as_object()->is_string_object());
auto underlying_string = static_cast<const StringObject*>(this_value.as_object())->primitive_string()->string();
ASSERT(this_object->is_string_object());
auto underlying_string = static_cast<const StringObject*>(this_object)->primitive_string()->string();
if (index < 0 || index >= static_cast<i32>(underlying_string.length()))
return js_string(interpreter.heap(), String::empty());
return js_string(interpreter.heap(), underlying_string.substring(index, 1));
return js_string(this_object->heap(), String::empty());
return js_string(this_object->heap(), underlying_string.substring(index, 1));
});
}