RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 06:37:35 +00:00
Code Issues Activity Actions

WebDriver: Inline Sesssion::stop() in session destructor

Browse source 
Previously it was possible to have following sequence of calls
while destroying a session:
1. `WebContentConnection::die()` calls `Client::close_session()`
2. `Client::close_session()` removes a session from active sessions
map which causes session destructor call.
3. Session destructor calls `Client::close_session()` to remove a
session from active sessions.

With `stop()` method inlined into destructor `close_session()` need
to be called just once while destroying a session.
This commit is contained in:
Aliaksandr Kalenik 2023-03-19 13:36:32 +03:00 • committed by Jelle Raaijmakers
parent b79cd5cf6e
commit 63c16ff41a
3 changed files with 23 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Services/WebDriver/Client.cpp
View file

@ -185,7 +185,7 @@ Web::WebDriver::Response Client::delete_session(Web::WebDriver::Parameters param
// 1. If the current session is an active session, try to close the session.
if (auto session = find_session_with_id(parameters[0]); !session.is_error())
TRY(session.value()->stop());
close_session(session.value()->session_id());
// 2. Return success with data null.
return JsonValue {};