mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 17:17:44 +00:00
LibJS: Move native objects towards two-pass construction
To make sure that everything is set up correctly in objects before we start adding properties to them, we split cell allocation into 3 steps: 1. Allocate a cell of appropriate size from the Heap 2. Call the C++ constructor on the cell 3. Call initialize() on the constructed object The job of initialize() is to define all the initial properties. Doing it in a second pass guarantees that the Object has a valid Shape and can find its own GlobalObject.
This commit is contained in:
parent
e4add19915
commit
64513f3c23
83 changed files with 295 additions and 167 deletions
|
@ -37,7 +37,8 @@ class Cell {
|
|||
AK_MAKE_NONMOVABLE(Cell);
|
||||
|
||||
public:
|
||||
virtual ~Cell() {}
|
||||
virtual void initialize(Interpreter&, GlobalObject&) { }
|
||||
virtual ~Cell() { }
|
||||
|
||||
bool is_marked() const { return m_mark; }
|
||||
void set_marked(bool b) { m_mark = b; }
|
||||
|
@ -56,14 +57,14 @@ public:
|
|||
virtual void visit_impl(Cell*) = 0;
|
||||
};
|
||||
|
||||
virtual void visit_children(Visitor&) {}
|
||||
virtual void visit_children(Visitor&) { }
|
||||
|
||||
Heap& heap() const;
|
||||
Interpreter& interpreter();
|
||||
Interpreter& interpreter() const;
|
||||
|
||||
protected:
|
||||
Cell() {}
|
||||
Cell() { }
|
||||
|
||||
private:
|
||||
bool m_mark { false };
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue